Multiple choice question gives 'Unexpected value'

[HalldorLyngmo]

When using a Multiple choice data type it will start giving errors if it's not answered, even if the question is not mandatory.

If there is a comma in the answer, it will also break.

Reproduction

If you're filing a bug, please describe how to reproduce it. Include as much
relevant information as possible, such as:

Bug summary

Since the lates update to 7.1.2 there seems to have been some changes to how Forms expects the answers. They have also become mandatory for some reason.

Specifics

Tested on Umbraco Cloud.
Umbraco 7.14.0
Forms 7.1.2
Google Chrome
Version 76.0.3809.132 (Official Build) (64-bit)

Not checked in other browsers

Steps to reproduce

1. Create a form and use the Multiple choice data type.

2. Add some pre-values. Don't check Field is mandatory.
   

3. Save it and try to submit the form
   

4. Fails unless you pick something

Expected result

Should not have pick anything, the form should submit.

Actual result

Can't submit unless I pick and if there is a comma in the pre value then you can't submit.

---

This item has been added to our backlog AB#2499

[HalldorLyngmo]

Also seeing the same issue on other data types. Such as Dropdown and Single choice.

[jgettrup]

I'd like to up-vote this issue for attention. Some forms on our site won't submit following the upgrade from v7.1.1 to 7.1.2. Our issue is that if there is a comma in a multiple choice prevalue, then the validation blocks the form from submitting.

[annatraversrose]

Please help with this issue. Thank you.

[frydenholm]

A rollback to Forms 7.1.1 have temporarily solved our issues.

[bergmania]

PR:

• V7: https://github.com/umbraco/Forms/pull/302
• V8: https://github.com/umbraco/Forms/pull/301

[bergmania]

Hotfix dll's if anyone can't wait for the official release (will be scheduled soon):

• V7 - UmbracoForms.Files.7.1.2-ci-20190903-001.zip
• V8 - UmbracoForms.Files.8.1.2.zip

In practice, only the bin/Umbraco.Forms.Web.dll is changed

[OlePc]

@bergmania I just tried the hotfix, and it solved it for radiobuttonlist and checkbuttonlist, but seems like the issue also exist on dropdownlists. Should I create a new issue for this?

[iuliaionescu]

Hi,
I had same issue as the ones described above. Changed the dll and that fixed some of my issues but there is still one though the one with the dropdownlist. If no option picked and submit the form I get the error from the screenshot.

[warrenbuckley]

@bergmania & @nul800sebastiaan it seems like it's this commit that has caused the problem, as its acceptable to not pick/set a value
https://github.com/umbraco/Forms/commit/de0455dd162f58b2ed5ed21d977745fe3403f86f

Will amend the PRs you have done Bjarke to allow an empty string as a valid value

Updated commit V8 - https://github.com/umbraco/Forms/pull/301/commits/f688d0578704537ee1f9c852b9a30427d938a5c2
Updated commit V7 - https://github.com/umbraco/Forms/pull/302/commits/5564c9d223dbb06fdc08886866d4cde99d13dad2

Updated Patch Files

This requires a newer version of the Dll Umbraco.Forms.Core @OlePc & @iuliaionescu can you please retry this updated patch fix for me and let us know it resolves the problem. Original reported issue along with dropdowns as well.

• V7 - UmbracoForms.Files.7.1.2-ci-20190904-001.zip
• V8 - UmbracoForms.Files.8.1.2_5564c9d.zip

---

@bergmania any idea what's up with the CI pipeline for Forms V8?!

[iuliaionescu]

@warrenbuckley thank you for the patch fix.
It works well ( v8 tested ) 👍

[OlePc]

@warrenbuckley Works for v7 also 👍