Server side validation fails to run if you put conditions on fieldsets

[lars-erik]

Server side validation fails to run if you put conditions on fieldsets.

UmbracoFormsController.ValidateFormState line two needs to do this:

var allValues = form.AllFields.ToDictionary(f => f.Id, f => String.Join(", ", model.FormState[f.Id.ToString()] ?? new object[0]));

The current use of f.Values always yields empty values, since it's a "dead" property.

[warrenbuckley]

Works as expected after some clarification/testing @bergmania

[lars-erik]

Whoops. There's a nullref exception hidden in there. Right code inc. Monday.

[lars-erik]

Replace

        var allValues = form.AllFields.ToDictionary(f => f.Id, f => String.Join(", ", model.FormState[f.Id.ToString()] ?? new object[0]));

with

        var allValues = form.AllFields.ToDictionary(f => f.Id, f => String.Join(", ", (
            model.FormState.ContainsKey(f.Id.ToString())
            ? model.FormState[f.Id.ToString()]
            : new object[0]
        ) ?? new object[0]));

[bergmania]

Hi @lars-erik,

I ended up resolving the issue in another way, instead of using the line you provided.
I don't think there is null-reference issues in the merged code.

[lars-erik]

OK. Will do some testing in production during next week, so crossing my fingers. :)