Skip to content

feat(uui-combobox): Add open functionality with space bar #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 7, 2025
Merged

feat(uui-combobox): Add open functionality with space bar #1170

merged 8 commits into from
Oct 7, 2025

Conversation

engijlr
Copy link
Contributor

@engijlr engijlr commented Aug 11, 2025

Added functionality to the combobox component to be able to open with the space bar but also allow selection with it.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1170.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1170.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1170.westeurope.azurestaticapps.net

iOvergaard
iOvergaard requested changes Oct 6, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1170.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1170.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1170.westeurope.azurestaticapps.net

@iOvergaard iOvergaard changed the title fix(uui-combobox): Add open functionality with space bar feat(uui-combobox): Add open functionality with space bar Oct 7, 2025
@iOvergaard iOvergaard added the accessibility A11Y improvements label Oct 7, 2025
@iOvergaard iOvergaard enabled auto-merge (squash) October 7, 2025 10:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1170.westeurope.azurestaticapps.net

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1170.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit db5207c into main Oct 7, 2025
11 of 12 checks passed
@iOvergaard iOvergaard deleted the v1/bugfix/combobox-select-on-space branch October 7, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
accessibility A11Y improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engijlr @iOvergaard @nielslyngsoe