Skip to content

uui button: ability to set title for button or A-tag #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2025
Merged

uui button: ability to set title for button or A-tag #1199

merged 4 commits into from
Oct 7, 2025

Conversation

nielslyngsoe
Copy link
Member

Ability to parse a title to the A-tag or button

@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 14:01
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) October 6, 2025 14:01
Copilot
Copilot AI reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the ability to set a title attribute on UUI button elements, which will be applied to both button and anchor tag variants of the component.

  • Added a new title property to the UUIButtonElement class
  • Applied the title attribute to both anchor (<a>) and button (<button>) elements in the template

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1199.westeurope.azurestaticapps.net

@nielslyngsoe @Copilot
Update packages/uui-button/lib/uui-button.element.ts
7647820 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1199.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe added the accessibility A11Y improvements label Oct 6, 2025
@nielslyngsoe nielslyngsoe merged commit c7556fc into main Oct 7, 2025
10 of 12 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/feature/uui-button-ability-to-set-title branch October 7, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
accessibility A11Y improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @iOvergaard