Skip to content

Sync disable state for uui-radio with uui-radio-group #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2023

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Jan 9, 2023

Description

Fixes #378

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Motivation and context

Best for keyboard navigation (and others) that the disabled state propagates from uui-radio-group to uui-radio.

How to test?

Check the "Disabled Group" story in Storybook.

@iOvergaard iOvergaard added the bug Something isn't working label Jan 9, 2023
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nielslyngsoe nielslyngsoe merged commit 3a62ebb into v1/contrib Jan 11, 2023
@nielslyngsoe nielslyngsoe deleted the v1/bugfix/radio-group branch January 11, 2023 08:37
iOvergaard added a commit that referenced this pull request Jan 11, 2023
Co-authored-by: Jesper Møller Jensen <26099018+JesmoDev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to disabled prop on uui-radio-group not propagating to child radio controls
3 participants