Skip to content

fix: Add whitespace when appending/prepending icon in uui-input #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2023
Merged

fix: Add whitespace when appending/prepending icon in uui-input #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e344d3a
alignment and whitespace
nathanwoulfe Jan 30, 2023
36dd3d3
fix padding in append example
nathanwoulfe Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/uui-icon/lib/uui-icon.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ export class UUIIconElement extends LitElement {
::slotted(svg) {
fill: var(--uui-icon-color, currentColor);
}

:host-context(div[slot='prepend']) {
margin-left: var(--uui-size-2, 6px);
}

:host-context(div[slot='append']) {
margin-right: var(--uui-size-2, 6px);
}
`,
];

Expand Down
36 changes: 36 additions & 0 deletions packages/uui-input/lib/uui-input.story.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,42 @@ export const PrependAndAppend: Story = props =>
</uui-input>
`;

export const PrependIcon: Story = props =>
html` <uui-input
.disabled=${props.disabled}
.readonly=${props.readonly}
.error=${props.error}
.label=${props.label}
.type=${props.type}
.name=${props.name}
.placeholder=${props.placeholder}
.value=${props.value}>
<div slot="prepend">
<uui-icon-registry-essential>
<uui-icon name="search"></uui-icon>
</uui-icon-registry-essential>
</div>
</uui-input>`;

export const AppendIcon: Story = props =>
html` <uui-input
.disabled=${props.disabled}
.readonly=${props.readonly}
.error=${props.error}
.label=${props.label}
.type=${props.type}
.name=${props.name}
.placeholder=${props.placeholder}
.value=${props.value}>
<div
slot="append"
style="background:#f3f3f3; padding-left:var(--uui-size-2, 6px)">
<uui-icon-registry-essential>
<uui-icon name="delete"></uui-icon>
</uui-icon-registry-essential>
</div>
</uui-input>`;

export const MultipleInputs: Story = props =>
html`
<uui-input
Expand Down