Skip to content

Conversation

JesmoDev
Copy link
Contributor

Description

This PR adds a new component: uui-textarea, that wraps the native textarea element with additional features such as auto height adjustment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@madsrasmussen
Copy link
Contributor

Hi Jesper,

It looks good!

A couple of things we should look at before we merge:

  • Dispatch an event on input as we do on change so you can listen for both input and change events on uui-textarea.
  • The label should follow the same styling as the uui-input label. Bold and with the same bottom margin to the textarea.
  • Add some padding inside the textarea. It should follow the same look as the uui-input.
  • Set the font family to "inherit" to use the correct font.
  • When we have added support for maxlength then I also think we should consider support for minlength. It is a "nice-to-have" now, we can always add it later.

@madsrasmussen madsrasmussen merged commit d5f378c into dev Nov 24, 2021
@madsrasmussen madsrasmussen deleted the feature/textarea branch November 24, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants