Skip to content
This repository was archived by the owner on Jun 18, 2018. It is now read-only.

Conversation

dawoe
Copy link

@dawoe dawoe commented May 29, 2017

No description provided.

@dawoe
Copy link
Author

dawoe commented May 29, 2017

For issue #128

@leekelleher
Copy link
Collaborator

@mattbrailsford - moving any discussion from #128 to here. Thoughts?
No rush though; (it's public holiday in the UK today)

@mattbrailsford
Copy link
Collaborator

mattbrailsford commented May 29, 2017

I get the reason, but I think just copying the content one is a bit of a code smell. What if you need one for members? or some other entity type? We are going to end up with multiple versions of the same code.

It would be much better to extend the first one to accept a "type" parameter so you can set the type of entity you are linking to (making it default to 'Document' for backwards compat). For none document nodes, it would change the syntax to:

{{ picker | ncNodeName:'Media' }}

To accept a type param, you'll need to change line 12 to include another param, but then just change line 37 to use that param (doing an undefined/null check first so that 'Document' is used by default).

@leekelleher
Copy link
Collaborator

@mattbrailsford oooo, TIL that Angular filters have params. 😎

@dawoe
Copy link
Author

dawoe commented May 30, 2017

Will try to update it.. just need to find some time to do it. A little bit swamped in work just before codegarden

@leekelleher leekelleher added this to the Umbraco 7.7.x milestone Aug 23, 2017
@leekelleher
Copy link
Collaborator

Closing the PR, as we don't want to introduce any features that are different to the Umbraco core version.
Please feel free to raise this with the Umbraco core team via their issue tracker.

@leekelleher leekelleher modified the milestone: Suggestions for Umbraco 7.7+ Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants