Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(concatenate): polyfill not replace in inner #1099

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Apr 25, 2024

a simple line takes me almost a whole day

Summary by CodeRabbit

  • New Features
    • Added test utilities for Jest injection and build result parsing.
    • Introduced functionality to test preservation of root named unchanged.
    • Added module optimization configuration settings for skipping and concatenating modules.
    • Introduced functionality to import and export modules.

Copy link
Contributor

coderabbitai bot commented Apr 25, 2024

Walkthrough

The changes introduce enhancements for scope hoisting polyfill replacement in a project. This includes new test utilities, configuration settings for module optimization, and the introduction of specific files for testing and functionality related to module preservation and optimization.

Changes

File(s) Summary
crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate/external_transformer.rs Added a new condition in ExternalTransformer implementation.
e2e/fixtures/mako.scope-hoisting.ployfill_replace/expect.js
e2e/fixtures/mako.scope-hoisting.ployfill_replace/mako.config.json
Introduce test utilities and configuration settings.
e2e/fixtures/mako.scope-hoisting.ployfill_replace/index.js
e2e/fixtures/mako.scope-hoisting.ployfill_replace/root.js
Implement functionality for testing preservation and module optimization.
e2e/fixtures/mako.scope-hoisting.ployfill_replace/inner.js Define a constant inner with specific initialization.

Poem

In the code's dance, new steps take flight,
Scope hoisting's magic, shining bright.
Buffers, modules, and tests align,
A rabbit's joy in code divine. 🐇✨

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Commits Files that changed from the base of the PR and between 56c09cc and 2208921.
Files selected for processing (6)
  • crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate/external_transformer.rs (1 hunks)
  • e2e/fixtures/mako.scope-hoisting.ployfill_replace/expect.js (1 hunks)
  • e2e/fixtures/mako.scope-hoisting.ployfill_replace/index.js (1 hunks)
  • e2e/fixtures/mako.scope-hoisting.ployfill_replace/inner.js (1 hunks)
  • e2e/fixtures/mako.scope-hoisting.ployfill_replace/mako.config.json (1 hunks)
  • e2e/fixtures/mako.scope-hoisting.ployfill_replace/root.js (1 hunks)

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@stormslowly stormslowly merged commit 145d70e into master Apr 25, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/buffer_not_replace_in_inner branch April 25, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant