Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write stats.json in dev when stats is configured #1108

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Apr 29, 2024

Close #1107

先用写 stats 的方式,后续改用 js api 传 stats。

Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

整体变更涉及到 mod.rs 中与生成统计信息和写入资源相关的逻辑流程的修改。具体来说,简化了生成统计信息的条件,并调整了写入资源的处理以包括处理资产复制的新代码块。此外,添加了一个新部分,用于处理不写入文件系统而是使用 jsapi 钩子的情况。

Changes

文件路径 变更摘要
crates/mako/src/generate/mod.rs 逻辑流程调整:简化生成统计信息的条件;调整写入资源的处理逻辑;添加新部分处理不写入文件系统而使用 jsapi 钩子。

Poem

小兔子编码忙,统计信息不再烦。
资产复制来调整,新代码段显神通。
不写入文件系统,jsapi钩子传数据。
代码改动如诗意,编程路上风景多。 🐇📝

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Commits Files that changed from the base of the PR and between e88750e and 0b7126a.
Files selected for processing (1)
  • crates/mako/src/generate/mod.rs (2 hunks)

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit 5fe7920 into master Apr 29, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sorrycc-78n9 branch April 29, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: also emit stats data in watch mode
1 participant