Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less plugin doesn't decoded path #1360

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Jul 2, 2024

.

Summary by CodeRabbit

  • 新功能

    • 在应用中添加了全局样式导入(global.less),增强了样式的一致性。
  • 样式

    • 新增全局样式文件 global.less,设置了 body 元素的文本颜色为黑色。
  • 优化

    • 更新了 lessLoader 函数,以确保文件路径正确解码。
  • 代码维护

    • 修改了预提交钩子脚本,改进了添加暂存文件的命令以提高效率。

Copy link
Contributor

coderabbitai bot commented Jul 2, 2024

Walkthrough

此次更新针对多项文件进行了修改,涵盖了预提交钩子脚本、样式导入以及路径解码等方面的功能优化。这些更改不仅提升了文件处理的可靠性,还改进了代码的可维护性和一致性。

Changes

文件路径 更改摘要
.husky/pre-commit 改变了添加暂存文件的命令,从 git add $(git diff ...) 改为 git diff ... -z | xargs -0 git add
e2e/fixtures/less.normal/.../index.tsx 添加了导入全局样式表 global.less 的语句
e2e/fixtures/less.normal/.../global.less 添加了新的样式文件 global.less,设置 body 元素的文本颜色为黑色
packages/mako/src/lessLoader/index.ts 在分配给 filename 前对 filePath 使用 decodeURIComponent 进行解码

👾🐰🖌️

代码焕新,预提交优化,
新增样式,黑色绽放,
文件路径,解码更涨,
兔子满心喜,功成在望!


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 15e722c and 55ec0cd.

Files selected for processing (4)
  • .husky/pre-commit (1 hunks)
  • e2e/fixtures/less.normal/src/index.tsx (1 hunks)
  • e2e/fixtures/less.normal/src/space space/global.less (1 hunks)
  • packages/mako/src/lessLoader/index.ts (1 hunks)
Files skipped from review due to trivial changes (3)
  • .husky/pre-commit
  • e2e/fixtures/less.normal/src/index.tsx
  • e2e/fixtures/less.normal/src/space space/global.less
Additional comments not posted (1)
packages/mako/src/lessLoader/index.ts (1)

32-32: 确保文件路径解码的正确性

代码更改将文件路径解码后赋值给 filename,这样可以处理编码的 URL 路径。然而,请确保所有传入的 filePath 都是有效的 URL 编码字符串,否则可能会导致解码错误。

@sorrycc sorrycc merged commit 0462371 into master Jul 3, 2024
8 checks passed
@stormslowly stormslowly deleted the fix/less_decoded_path branch August 9, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants