-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: less plugin doesn't decoded path #1360
Conversation
Walkthrough此次更新针对多项文件进行了修改,涵盖了预提交钩子脚本、样式导入以及路径解码等方面的功能优化。这些更改不仅提升了文件处理的可靠性,还改进了代码的可维护性和一致性。 Changes
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .husky/pre-commit (1 hunks)
- e2e/fixtures/less.normal/src/index.tsx (1 hunks)
- e2e/fixtures/less.normal/src/space space/global.less (1 hunks)
- packages/mako/src/lessLoader/index.ts (1 hunks)
Files skipped from review due to trivial changes (3)
- .husky/pre-commit
- e2e/fixtures/less.normal/src/index.tsx
- e2e/fixtures/less.normal/src/space space/global.less
Additional comments not posted (1)
packages/mako/src/lessLoader/index.ts (1)
32-32
: 确保文件路径解码的正确性代码更改将文件路径解码后赋值给
filename
,这样可以处理编码的 URL 路径。然而,请确保所有传入的filePath
都是有效的 URL 编码字符串,否则可能会导致解码错误。
.
Summary by CodeRabbit
新功能
global.less
),增强了样式的一致性。样式
global.less
,设置了body
元素的文本颜色为黑色。优化
lessLoader
函数,以确保文件路径正确解码。代码维护