Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ patch on demand #709

Merged
merged 2 commits into from
Jul 3, 2020
Merged

✨ patch on demand #709

merged 2 commits into from
Jul 3, 2020

Conversation

howel52
Copy link
Collaborator

@howel52 howel52 commented Jul 2, 2020

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@howel52 howel52 requested review from kuitos and Deturium July 2, 2020 10:55
kuitos
kuitos approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anLl
Copy link

anLl commented Jul 3, 2020

这个是在合并打版了么，^_^

Deturium
Deturium approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@Deturium Deturium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos kuitos merged commit b57762d into umijs:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deturium Deturium Deturium approved these changes

@kuitos kuitos kuitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IE11无法启动,[import-html-entry] Here is no "fetch" on the window env, you need to polyfill it
4 participants
@howel52 @anLl @kuitos @Deturium