Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vue router tips #721

Merged
merged 7 commits into from
Jul 7, 2020
Merged

docs: add vue router tips #721

merged 7 commits into from
Jul 7, 2020

Conversation

screetBloom
Copy link
Contributor

@screetBloom screetBloom commented Jul 3, 2020

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

add a FAQ about Vue Router


Some background information:
  • I'm having some problems when use vue router in qiankun. I hope I can share some of my experience with others.
  • And this is my first contribution to qiankun, I am eager to get this merged . Thx~

@kuitos



@screetBloom
Copy link
Contributor Author

screetBloom commented Jul 3, 2020

Some checks were not successful !
But this looks like it's due to an external cause 👇.

image

Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充一下英文文档部分?

@kuitos
Copy link
Member

kuitos commented Jul 6, 2020

merge with master then the ci failure will gone

@screetBloom
Copy link
Contributor Author

补充一下英文文档部分?

好的,收到

@screetBloom screetBloom requested a review from kuitos July 6, 2020 12:19
@screetBloom
Copy link
Contributor Author

我使用 sub-app 的原因:https://en.wiktionary.org/wiki/subapplication

根据wiki来看,应该是subapplication 或者 sub-app

@kuitos 你看一下是否认可,如果不认可的话我快速改一下

docs/faq/README.md Outdated Show resolved Hide resolved
docs/faq/README.md Outdated Show resolved Hide resolved
docs/faq/README.md Outdated Show resolved Hide resolved
docs/faq/README.md Outdated Show resolved Hide resolved
@screetBloom screetBloom requested a review from kuitos July 7, 2020 05:08
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your nice work!

@kuitos kuitos merged commit 2e9e3d1 into umijs:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants