Get global state

[tcper]

Checklist

• npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• As a global message bus, I think onGlobalStateChange is not enough.
• Add convenient get global state data

[kuitos]

@dbkillerf6

[kuitos]

IMO getGlobalState is not necessary, you could use onGlobalStateChange(state => {}, true) to simulate getGlobalState instead, who combined getter and observer into one ,inspired by rxjs Subject.subscribe design philosophy.

[tcper]

IMO getGlobalState is not necessary, you could use onGlobalStateChange(state => {}, true) to simulate getGlobalState instead, who combined getter and observer into one ,inspired by rxjs Subject.subscribe design philosophy.

Saw it, I think it's doable,
But it is redundancy, fold a getter function into a closure.

[kuitos]

But it is redundancy, fold a getter function into a closure.

Not agreed, it is a common design in reactive programming with my knowledge.

[tcper]

But it is redundancy, fold a getter function into a closure.

Not agreed, it is a common design in reactive programming with my knowledge.

A simple stage, click button pop up a bubble

onClick = () => {
  message.info(getCurrentGlobalState());
}

Your way

onClick = () => {
  onGlobalStateChange(state => {
    message.info(state);
  }, true);
}

I think we need more readable code more than great philosophy.
Without your inform, I didn't even notice this immediate fire thing.

[kuitos]

Keep acquisition and subscription consistently is basic design principle in reactive programming, not such a great philosophy imo, it can help the right way practice of single source of truth and avoid the abuse of global state.

[dbkillerf6]

@kuitos
I think @tcper needs an API to get the global state synchronously. In theory, this behavior can be allowed if it is only reading.
But even so, I recommend subscribing the global data to sub-app and then reading the data in the app if your global state contains page rendering data.

[fengxianqi]

I think it is necessary to add a getGlobalState api. Sub-app can easily get father's store when mount instead of using onGlobalChange.

[wibed]

I too would prefer a synchronous store access method.
or can someone explain how I can export state directly?

something like

const test = onGlobalState(state => { return state.test }, true)

because at the moment it is looking like

function testGet(){
  let test: any
  onGlobalState(state => { test = state.test }, true)
  return test
}

[yuki070]

Let's see my solutions.

https://github.com/yuki070/qiankun-redux

I use redux to make the global state instead of initGlobalState. Of course, this also can be do in qiankun itself.

[YuhuiRainie]

I vote for "getGlobalState"

[kuitos]

closed via we will not recommend global state api at next major version

[A-floweR-y]

But it is redundancy, fold a getter function into a closure.

Not agreed, it is a common design in reactive programming with my knowledge.

A simple stage, click button pop up a bubble

onClick = () => {
  message.info(getCurrentGlobalState());
}

Your way

onClick = () => {
  onGlobalStateChange(state => {
    message.info(state);
  }, true);
}

I think we need more readable code more than great philosophy. Without your inform, I didn't even notice this immediate fire thing.

@kuitos I think getGlobalState sounds better.

The first time I used qiankun, I tried to retrieve the state content set by the initGlobalState method through onGlobalStateChange(callback) but found it not executing. I have been searching for a method like getGlobalState or whether globalState is globally mounted. I consulted the documentation and used Google search, but did not find the required information until I visited GitHub and discovered that the onGlobalStateChange method has a second parameter, which when set to true is similar to getGlobalState.