Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 not proxy document anymore to avoid causing dom type checking exception #846

Merged
merged 5 commits into from
Aug 10, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Aug 10, 2020

changelist:

  1. 合并了 appendChild 和 insertBefore 方法的重写
  2. 不再代理 document,改为重写 Document.prototype.createElement 并从 this 中确认当前沙箱身份
Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

This change is Reviewable

@kuitos kuitos requested review from howel52 and Deturium and removed request for howel52 August 10, 2020 10:33
howel52
howel52 previously approved these changes Aug 10, 2020
Copy link
Collaborator

@howel52 howel52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants