Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 record global mutation in addons while remounting #847

Merged
merged 1 commit into from
Aug 10, 2020
Merged

🐛 record global mutation in addons while remounting #847

merged 1 commit into from
Aug 10, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Aug 10, 2020 •
edited
Loading

remount 时由于沙箱还未 active，导致在 addons 的 beforeMount 里的 global mutation 无法被沙箱记录

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

This change is Reviewable

@kuitos kuitos requested a review from Deturium August 10, 2020 14:21
@howel52
Copy link
Collaborator

howel52 commented Aug 10, 2020

LGTM

@kuitos kuitos merged commit f7009fb into master Aug 10, 2020
@kuitos kuitos deleted the fix/sandbox-running-not-set-while-remounting branch August 10, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howel52 howel52 howel52 approved these changes

@Deturium Deturium Awaiting requested review from Deturium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuitos @howel52