Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ simulate document currentScript while dynamic loading #899

Merged
merged 2 commits into from
Aug 26, 2020
Merged

✨ simulate document currentScript while dynamic loading #899

merged 2 commits into from
Aug 26, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Aug 25, 2020 •
edited
Loading

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

This change is Reviewable

howel52
howel52 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@howel52 howel52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Deturium
Deturium approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@Deturium Deturium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos kuitos merged commit b489b3e into master Aug 26, 2020
@kuitos kuitos deleted the feat/simulate-document-currentScript branch August 26, 2020 03:32
kuitos added a commit that referenced this pull request May 29, 2022
@kuitos
✨ simulate document currentScript while dynamic loading (#899)
7a538cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deturium Deturium Deturium approved these changes

@howel52 howel52 howel52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuitos @howel52 @Deturium