Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix NodeList forEach method compatibility problem #965

Merged
merged 1 commit into from
Sep 29, 2020
Merged

🐛 fix NodeList forEach method compatibility problem #965

merged 1 commit into from
Sep 29, 2020

Conversation

stoneChen
Copy link
Contributor

@stoneChen stoneChen commented Sep 28, 2020 •
edited
Loading

Checklist
  • npm test passes
  • commit message follows commit guidelines
Description of change

const styleNodes = element.querySelectorAll('style') 返回的是NodeList，在chrome51才开始支持，兼容之。

image

kuitos
kuitos approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your nice work!

@kuitos kuitos merged commit 3217e2e into umijs:master Sep 29, 2020
kuitos pushed a commit that referenced this pull request May 29, 2022
@stoneChen
🐛 use lodash forEach instead to traverse NodeList for compatible reas…
613f6d2 
…on (#965)

Co-authored-by: 陈师东 <chensd@servyou.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuitos kuitos kuitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoneChen @kuitos