Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade babel to 7.0.0-beta.53 #544

Closed
sorrycc opened this issue May 24, 2018 · 4 comments
Closed

Upgrade babel to 7.0.0-beta.53 #544

sorrycc opened this issue May 24, 2018 · 4 comments
Labels
type(enhancement)
Milestone
umi@2.0

Comments

@sorrycc
Copy link
Member

sorrycc commented May 24, 2018

ref

it fixed #413
@xiaohuoni
Copy link
Member

真早啊

@dgeibi
Copy link

dgeibi commented May 25, 2018 •
edited
Loading

babel/babel#8050

我想多了。静态属性的继承，其实很少用。所以直接升级版本号没什么大问题。

另外Object.setPrototypeOf的 polyfill 要去掉，babel 的 getPrototypeOf helper 才能获取 __proto__

https://github.com/babel/babel/blob/v7.0.0-beta.49/packages/babel-helpers/src/helpers.js#L421-L430

@sorrycc sorrycc added this to the umi@2.0 milestone Jun 26, 2018
@yoyo837
Copy link

yoyo837 commented Jun 27, 2018

看来还是得等升级babel...

This was referenced Jun 27, 2018
Closed
Closed
Merged
@sorrycc sorrycc changed the title Upgrade babel to 7.0.0-beta.48 Upgrade babel to 7.0.0-beta.53 Jul 15, 2018
@sorrycc sorrycc mentioned this issue Aug 10, 2018
Merged
1 task
@lixuguang1988 lixuguang1988 mentioned this issue Nov 8, 2018
Closed
@lixuguang1988
Copy link

@dgeibi

另外Object.setPrototypeOf的 polyfill 要去掉，babel 的 getPrototypeOf helper 才能获取 proto

这个怎么操作，我npm install --save-dev @babel/helpers 无效，去了就报错了，

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type(enhancement)
Projects
None yet
Milestone
umi@2.0
Development

No branches or pull requests
5 participants
@sorrycc @dgeibi @lixuguang1988 @yoyo837 @xiaohuoni