Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: is React Component #4454

Merged
merged 2 commits into from
Apr 14, 2020
Merged

fix: is React Component #4454

merged 2 commits into from
Apr 14, 2020

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Apr 14, 2020

Close #4452

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #4454 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4454      +/-   ##
==========================================
+ Coverage   82.78%   82.79%   +0.01%     
==========================================
  Files         144      144              
  Lines        2892     2895       +3     
  Branches      724      724              
==========================================
+ Hits         2394     2397       +3     
+ Misses        490      489       -1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
...kages/ast/src/isReactComponent/isReactComponent.ts 100.00% <100.00%> (ø)
packages/core/src/Config/Config.ts 61.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edbf632...a436616. Read the comment docs.

@ycjcl868 ycjcl868 requested a review from sorrycc April 14, 2020 04:34
@sorrycc sorrycc merged commit ac06d95 into master Apr 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-is-react-element branch April 14, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[缺陷]umi在过滤非react组件时无法识别纯字符串返回以及模板中tsconfig的include缺失
2 participants