Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo: forkTSCheker -> forkTSChecker #4590

Merged
merged 4 commits into from
May 6, 2020
Merged

Conversation

sunnylqm
Copy link
Contributor

@sunnylqm sunnylqm commented May 5, 2020

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #4590 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4590   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files         144      144           
  Lines        2898     2898           
  Branches      721      716    -5     
=======================================
  Hits         2398     2398           
- Misses        491      492    +1     
+ Partials        9        8    -1     
Impacted Files Coverage Δ
...set-built-in/src/plugins/features/forkTSChecker.ts 70.00% <50.00%> (ø)
packages/core/src/Config/Config.ts 61.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fc715...577cf48. Read the comment docs.

@ycjcl868
Copy link
Contributor

ycjcl868 commented May 6, 2020

可能会有 breakChange,@sorrycc

@ycjcl868
Copy link
Contributor

ycjcl868 commented May 6, 2020

这个用的不多,可以及时先改,

@ycjcl868
Copy link
Contributor

ycjcl868 commented May 6, 2020

和 umi 3.2.0 一起发吧

@sorrycc sorrycc merged commit 45a5a66 into umijs:master May 6, 2020
@gao-sun
Copy link

gao-sun commented Jul 11, 2020

I'm really shocked about this kind of typo and how did it pass code review, also the reply & typo in comment. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants