Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support TypeScript DI #4929

Merged
merged 5 commits into from
Aug 13, 2020
Merged

feat: support TypeScript DI #4929

merged 5 commits into from
Aug 13, 2020

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Jun 29, 2020 •
edited
Loading

Close #5215

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@ycjcl868 ycjcl868 requested a review from sorrycc June 29, 2020 09:48
@weekly-digest weekly-digest bot mentioned this pull request Jul 5, 2020
Closed
@weekly-digest weekly-digest bot mentioned this pull request Aug 2, 2020
Closed
@DiamondYuan DiamondYuan mentioned this pull request Aug 13, 2020
Closed
sorrycc
sorrycc reviewed Aug 13, 2020
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@sorrycc
Copy link
Member

sorrycc commented Aug 13, 2020

babel-preset-umi 下加个用例。

@ycjcl868
Copy link
Contributor Author

babel-preset-umi 下加个用例。

done

@codecov
Copy link

codecov bot commented Aug 13, 2020 •
edited
Loading

Codecov Report

Merging #4929 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4929   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files         151      151           
  Lines        3353     3354    +1     
  Branches      892      889    -3     
=======================================
+ Hits         2784     2785    +1     
  Misses        562      562           
  Partials        7        7
Impacted Files Coverage Δ
packages/babel-preset-umi/src/index.ts 85.71% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5084e...1c4bd2e. Read the comment docs.

@sorrycc sorrycc merged commit b56f7f6 into master Aug 13, 2020
kuitos pushed a commit that referenced this pull request Sep 10, 2020
@ycjcl868 @kuitos
feat: support TypeScript DI (#4929)
5c8904c 
* feat: typescript di

* chore: create umi

* fix: test csae

* chore: unused code

* chore: tsconfig.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorrycc sorrycc sorrycc left review comments

@DiamondYuan DiamondYuan DiamondYuan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

umi3 typedi not work
3 participants
@ycjcl868 @sorrycc @DiamondYuan