Skip to content

Conversation

deoxxa
Copy link

@deoxxa deoxxa commented Apr 10, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 93.71% when pulling 10ad98f on deoxxa:add-lock-clause into 7f381db on umisama:master.

@umisama
Copy link
Owner

umisama commented May 8, 2015

I'm sorry to have got to wait for you because I miss this PR.

LOCK clause is supported by only PostgresSQL. Can you write this to godoc clearly?

@yosida95
Copy link

@umisama LOCK clause (row level lock) is not supported by only PostgreSQL but also MySQL (InnoDB engine).

However this patch won't work in MySQL because MySQL uses SELECT ... LOCK IN SHARE MODE clause to represent shared lock, like described in https://dev.mysql.com/doc/refman/5.7/en/innodb-locking-reads.html.

@umisama
Copy link
Owner

umisama commented May 10, 2015

thank you yosida95. I've checked LOCK clause is supported by InnoDB but it is not standard SQL.
I want to compatible around DB engines as much as possible.

@deoxxa
Copy link
Author

deoxxa commented May 11, 2015

Perhaps it would be better if the functions were named PostgresLocks and PostgresLock? That way it'd be very clear that they only work in Postgres.

@umisama
Copy link
Owner

umisama commented May 12, 2015

Hmm, I hope using dialect to compatible with mysql.

OK! I'll implement LOCK clause with your idea!
Please wait few days!

@deoxxa deoxxa force-pushed the add-lock-clause branch from 10ad98f to e49241f Compare June 22, 2015 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants