Add new home page sidebar [WiP] #82
Conversation
|
Important Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes introduce a Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant SpeciesSearchBar
participant HomeSideBar
participant useHomeSideBar
participant useSpeciesSearchBar
User->>SpeciesSearchBar: Input search query
SpeciesSearchBar->>useSpeciesSearchBar: Handle input change
SpeciesSearchBar->>useSpeciesSearchBar: Handle key press
SpeciesSearchBar->>useSpeciesSearchBar: Handle search button click
useSpeciesSearchBar->>HomeSideBar: Trigger search action
HomeSideBar->>useHomeSideBar: Update search query
useHomeSideBar->>navigate: Navigate to search results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (14)
- frontend/src/components/elements/SpeciesSearchBar/SpeciesSearchBar.stories.tsx (1 hunks)
- frontend/src/components/elements/SpeciesSearchBar/SpeciesSearchBar.tsx (1 hunks)
- frontend/src/components/elements/SpeciesSearchBar/hooks.ts (1 hunks)
- frontend/src/components/elements/SpeciesSearchBar/index.ts (1 hunks)
- frontend/src/components/elements/SpeciesSearchBar/styles.scss (1 hunks)
- frontend/src/components/elements/SpeciesSearchBar/types.ts (1 hunks)
- frontend/src/components/index.ts (1 hunks)
- frontend/src/components/sidebar/HomeSideBar/HomeSideBar.stories.tsx (1 hunks)
- frontend/src/components/sidebar/HomeSideBar/HomeSideBar.tsx (1 hunks)
- frontend/src/components/sidebar/HomeSideBar/hooks.ts (1 hunks)
- frontend/src/components/sidebar/TreeSidePane/TreeSidePane.stories.tsx (1 hunks)
- frontend/src/components/sidebar/TreeSidePane/hooks.ts (1 hunks)
- frontend/src/index.css (1 hunks)
- frontend/src/sample-data.ts (1 hunks)
Files not reviewed due to errors (3)
- frontend/src/components/sidebar/TreeSidePane/hooks.ts (no review received)
- frontend/src/components/sidebar/TreeSidePane/TreeSidePane.stories.tsx (no review received)
- frontend/src/sample-data.ts (no review received)
Files skipped from review due to trivial changes (8)
- frontend/src/components/elements/SpeciesSearchBar/SpeciesSearchBar.stories.tsx
- frontend/src/components/elements/SpeciesSearchBar/index.ts
- frontend/src/components/elements/SpeciesSearchBar/styles.scss
- frontend/src/components/elements/SpeciesSearchBar/types.ts
- frontend/src/components/index.ts
- frontend/src/components/sidebar/HomeSideBar/HomeSideBar.stories.tsx
- frontend/src/components/sidebar/HomeSideBar/HomeSideBar.tsx
- frontend/src/index.css
Additional Context Used
Biome (25)
frontend/src/components/elements/SpeciesSearchBar/SpeciesSearchBar.tsx (2)
9-10: All these imports are only used as types.
30-30: Provide an explicit type prop for the button element.
frontend/src/components/elements/SpeciesSearchBar/hooks.ts (1)
4-5: All these imports are only used as types.
frontend/src/components/sidebar/TreeSidePane/TreeSidePane.stories.tsx (1)
5-6: All these imports are only used as types.
frontend/src/components/sidebar/TreeSidePane/hooks.ts (1)
5-6: All these imports are only used as types.
frontend/src/sample-data.ts (20)
11-11: The computed expression can be simplified without the use of a string literal.
12-12: The computed expression can be simplified without the use of a string literal.
13-13: The computed expression can be simplified without the use of a string literal.
14-14: The computed expression can be simplified without the use of a string literal.
15-15: The computed expression can be simplified without the use of a string literal.
16-16: The computed expression can be simplified without the use of a string literal.
17-17: The computed expression can be simplified without the use of a string literal.
18-18: The computed expression can be simplified without the use of a string literal.
19-19: The computed expression can be simplified without the use of a string literal.
20-20: The computed expression can be simplified without the use of a string literal.
21-21: The computed expression can be simplified without the use of a string literal.
22-22: The computed expression can be simplified without the use of a string literal.
25-25: The computed expression can be simplified without the use of a string literal.
26-26: The computed expression can be simplified without the use of a string literal.
27-27: The computed expression can be simplified without the use of a string literal.
28-28: The computed expression can be simplified without the use of a string literal.
29-29: The computed expression can be simplified without the use of a string literal.
30-30: The computed expression can be simplified without the use of a string literal.
31-31: The computed expression can be simplified without the use of a string literal.
32-32: The computed expression can be simplified without the use of a string literal.
| export const useHomeSideBar = () => { | ||
| // Remember search query across sessions. | ||
| const { searchQuery, setSearchQuery } = useSearchQuery(); | ||
|
|
||
| const navigate = useNavigate(); | ||
|
|
||
| const handleSearch = (query: string) => { | ||
| console.debug(`Searching for: ${query}`); | ||
| mainBus.emit("before_search"); | ||
| mainBus.emit("search", query); | ||
|
|
||
| setSearchQuery(query); | ||
| navigate(routes.search(query)); | ||
| }; | ||
|
|
||
| return { | ||
| handleSearch, | ||
| searchQuery, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Consider adding error handling and user feedback mechanisms for the search operation.
| import { useEffect, useState } from "react"; | ||
|
|
||
| // Local imports. | ||
| import { IProps } from "./types.ts"; |
There was a problem hiding this comment.
Use TypeScript's import type syntax for type-only imports to prevent potential side effects.
- import { IProps } from "./types.ts";
+ import type { IProps } from "./types.ts";Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| import { IProps } from "./types.ts"; | |
| import type { IProps } from "./types.ts"; |
The new sidebar should provide better search function for desktop and mobile users.
Summary by CodeRabbit
New Features
SpeciesSearchBarcomponent for tree searches.HomeSideBarcomponent with integratedSpeciesSearchBar.Enhancements
TreeSidePanecomponent with improved status line formatting.Bug Fixes
TreeSidePanein Storybook for better organization.Documentation
SpeciesSearchBarandHomeSideBarcomponents.Data Updates
SAMPLE_TREEobject with new properties for better data representation.