Improving colour of selected states in UmpleOnline more S less V Fixes #1705 #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimLethbridge
changed the title
|
The umpleversion.last.txt should not have been committed, so I reverted it. The new proposed colour was made darker but asince it was too unsaturated (trending towards grey) it didn't look nice. I changed so it was more saturated and I also reduced the change in brightness. This should still stand out better than the previous colour, but looks nicer. Also the PR description was not as useful before. I added the fixed message, and more clearly state what it does. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Umpleonline code to highlight the top menu in deep color when selected. Fixes #1705