Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify deprecation messages #1026

Merged
merged 1 commit into from
May 25, 2021
Merged

Clarify deprecation messages #1026

merged 1 commit into from
May 25, 2021

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented May 25, 2021

It turned out we don't really want to break users configurations, so deprecated values stay with us at least before 2.0 is released.

Turned out we don't really want to break
users configurations, so deprecated values
stay with us at least before 2.0 is released.
@paskal paskal force-pushed the paskal/deprecation_update branch from e6f9fde to 812e9b3 Compare May 25, 2021 19:35
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #1026 (812e9b3) into master (8d8c6ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1026   +/-   ##
=======================================
  Coverage   44.01%   44.01%           
=======================================
  Files         127      127           
  Lines        2906     2906           
  Branches      656      656           
=======================================
  Hits         1279     1279           
  Misses       1615     1615           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13fa22...812e9b3. Read the comment docs.

@umputun umputun merged commit 1cff4eb into master May 25, 2021
@umputun umputun deleted the paskal/deprecation_update branch May 25, 2021 19:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 876130532

  • 7 of 12 (58.33%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 83.662%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/app/main.go 0 2 0.0%
backend/app/cmd/server.go 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
backend/app/main.go 1 70.59%
Totals Coverage Status
Change from base Build 875954404: 0.03%
Covered Lines: 5438
Relevant Lines: 6500

💛 - Coveralls

@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants