Separate user and admin notifications #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
changed the title
paskal
force-pushed
the
paskal/clarify_notifications
branch
from
140a2a2
to
0077e3e
Compare
paskal
force-pushed
the
paskal/clarify_notifications
branch
from
0077e3e
to
1e0d575
Compare
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
=======================================
Coverage 43.97% 43.97%
=======================================
Files 127 127
Lines 2906 2906
Branches 658 658
=======================================
Hits 1278 1278
Misses 1616 1616
Partials 12 12 Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 876262489
💛 - Coveralls |
|
I found the naming to be extremely confusing. As I read UserTypes my brain immediately translates it to "types of users". Not sure what will be the better name here |
The current state is a mess of user and admin notifications, which will become worse after implementing the new user notification methods like a telegram. This change makes things simpler for the remark42 users.
paskal
force-pushed
the
paskal/clarify_notifications
branch
from
1e0d575
to
0321c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current state is a mess of user and admin notifications, which will become worse after implementing the new user notification methods like a telegram.
This change makes things simpler for the remark42 users.
Can be merged after #1026 will be merged.