Map grid #11
Map grid #11
Conversation
still improvements necessary for feature selection and layer hiding
| @@ -12,15 +12,16 @@ | |||
| <wave-layer-list class="mat-elevation-z4" [height]="middleContainerHeight$ | async"></wave-layer-list> | |||
|
|
|||
| <div class="mid-container" [style.height.px]="middleContainerHeight$ | async"> | |||
| <wave-ol-map #map> | |||
There was a problem hiding this comment.
If we add another map we have to indicate the type in the container name.
There was a problem hiding this comment.
Maybe you can clarify your suggestion, because I think I do not get your point.
My thoughts by now:
- we only use one map component
- #map is used to access the component from
app.component. - I don't know the type of a map. And usually I resist coding types into variable names.
There was a problem hiding this comment.
oh i was thinking of cesium, harp.gl, ... as alternative to openlayers. Then we would have wave-ol-map, wave-cesium-map, ...
There was a problem hiding this comment.
I think this would be a major change that needs a lot of refactoring then. Now, it's the only option and it is more than just one ol map - it is potentially a grid of maps. So I would leave it like this for now.
| resultSymbology = ComplexPointSymbology.createClusterSymbology({ | ||
| fillRGBA: this.randomColorService.getRandomColorRgba(), | ||
| }); | ||
| clustered = true; |
There was a problem hiding this comment.
I don't think that the default style for points from user input should be clustered
There was a problem hiding this comment.
I thought it was useless to use a cluster symbology without having this parameter set to be true. But I could change it to unclustered, but then with SimplePointSymbology.
The map has now the possibility to show layers stacked as well as in a synchronized grid.