Allow for proxy_count of exact 0 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraKraBa
reviewed
Apr 18, 2024
python_ipware/python_ipware.py
Outdated
|
|
||
| # the incoming ips match our proxy count | ||
| if self.proxy_count > 0 and proxy_count_validated: | ||
| if self.proxy_count and self.proxy_count > 0 and proxy_count_validated: |
There was a problem hiding this comment.
Here I would just check if self.proxy_count is not None and proxy_count_validated because self.proxy_count = 0 now also means that the proxy_count did go through validation. If I change this, I have to adapt the tests test_proxy_count_zero_dont_care_proxy_pass and test_proxy_count_zero_exact_zero_proxy_pass.
FraKraBa
reviewed
Apr 18, 2024
python_ipware/python_ipware.py
Outdated
| precedence: Optional[Tuple[str, ...]] = None, | ||
| leftmost: bool = True, | ||
| proxy_count: int = 0, | ||
| leftmost: Optional[bool] = True, |
There was a problem hiding this comment.
I'm not sure why you make leftmost an Optional[bool]. Passing leftmost=None seems to have the same effect as leftmost=False.
There was a problem hiding this comment.
Typing stuff. It is a boolean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for proxy_count of exact 0