Add :by option to increment and decrement #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why is this change necessary:** clojure-dogstatsd-client didn't have a way to increment or decrement by a value different than one. **How does this change address the issue:** Add an optional `:by` option to the increment and decrement function. Implement `increment` and `decrement` by calling java-dogstatsd-client's `count` method, which supports incrementing or decrementing by other values than one. (This is the method that java-dogstatsd-client's `incrementCount` and `decrementCount` call.) Add unit tests.
rymndhng
reviewed
Jan 12, 2020
| @@ -41,29 +41,29 @@ | |||
| (when-not (and client once?) | |||
| (shutdown!) | |||
| (alter-var-root #'client (constantly | |||
| (com.timgroup.statsd.NonBlockingStatsDClient. | |||
| (NonBlockingStatsDClient. | |||
There was a problem hiding this comment.
This is covered by the import line in the module above, is it necessary to fully qualify this?
There was a problem hiding this comment.
Exactly, the class is imported into the current namespace, so I changed the code to refer to it directly instead of fully qualifying it. (Not sure I understand your question?)
This is just a small clean-up edit, unrelated to the new feature. Fine to revert it if you'd prefer the fully qualified name.
There was a problem hiding this comment.
ah okay, I gotcha. Sorry I was reading the PR backwards 😅
rymndhng
reviewed
Jan 12, 2020
README.md
Outdated
| @@ -24,6 +24,7 @@ Somewhere in your code, you should setup the client: | |||
|
|
|||
| ;; Increment or derement a counter | |||
| (statsd/increment "counter") | |||
| (statsd/increment "counter" {:by 2.5 :sample-rate 3.3 :tags ["foo" "bar"]}) | |||
There was a problem hiding this comment.
I'd suggest removing sample-rate and tags and add a comment to describe what by is intended to do :)
|
Thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary:
clojure-dogstatsd-client didn't have a way to increment or decrement
by a value different than one.
How does this change address the issue:
Add an optional
:byoption to the increment and decrement function.Implement
incrementanddecrementby callingjava-dogstatsd-client's
countmethod, which supports incrementing ordecrementing by other values than one. (This is the method that
java-dogstatsd-client's
incrementCountanddecrementCountcall.)Add unit tests.