Apply design changes to proposal details #726
Conversation
allbecauseyoutoldmeso
force-pushed
the
kg-proposal-details
branch
7 times, most recently
from
0052f9a
to
4bfd988
Compare
| end | ||
| end | ||
|
|
||
| private | ||
| def proposal_detail_groups_with_numbers |
There was a problem hiding this comment.
Proposal details have to be numbered before they are filtered, so that if question 2 is filtered out, question 3 is still question 3!
| @@ -1,7 +1,7 @@ | |||
| <div class="govuk-accordion__section"> | |||
| <div class="govuk-accordion__section-header"> | |||
| <h3 class="govuk-accordion__section-heading"> | |||
| <button type="button" id="accordion-default-heading-2" aria-controls="accordion-default-heading-3" class="govuk-accordion__section-button" aria-expanded="false"> | |||
| <button type="button" id="accordion-default-heading-3" aria-controls="accordion-default-heading-3" class="govuk-accordion__section-button" aria-expanded="false"> | |||
There was a problem hiding this comment.
I think this was a typo. accordion-default-heading-2 is the ID for the 'Site map' accordion as well. That uses it consistently, whereas this is mainly using accordion-default-heading-3.
| <path fill="currentColor" d="M6.5 0L0 6.5 1.4 8l4-4v12.7h2V4l4.3 4L13 6.4z"></path> | ||
| </svg> | ||
| <p><%= t(".back_to_top") %></p> | ||
| <% end %> |
There was a problem hiding this comment.
There's currently no 'Back to top' link in the gov UK design system, although there's one used on their site, and an open issue to discuss it.
I've put this in a shared partial so we can use it as needed until, hopefully, an official one is added!
allbecauseyoutoldmeso
force-pushed
the
kg-proposal-details
branch
5 times, most recently
from
51c18d5
to
515e51f
Compare
| @@ -279,7 +279,7 @@ jobs: | |||
| env: | |||
| DATABASE_URL: postgres://postgres:postgres@localhost:5432/test | |||
| RAILS_ENV: test | |||
| SPEC_OPTS: "-f doc -P spec/{helpers,presenters,mailer,jobs,services}/**/*_spec.rb" | |||
| SPEC_OPTS: "-f doc -P spec/{helpers,presenters,mailer,jobs,services,translations}/**/*_spec.rb" | |||
There was a problem hiding this comment.
Just spotted that we're not actually running the specs for i18n configuration in github actions 😬
Yes of course...this was a painful piece of work so grateful for other eyes on it! Any time today works for me I think. |
allbecauseyoutoldmeso
force-pushed
the
kg-proposal-details
branch
from
a16729c
to
dd29ed3
Compare
allbecauseyoutoldmeso
force-pushed
the
kg-proposal-details
branch
5 times, most recently
from
86046ac
to
74a3b1d
Compare
- Change styling of anchor links - Update copy - Allow filtering by 'auto answered' - Add 'back to top' links
allbecauseyoutoldmeso
force-pushed
the
kg-proposal-details
branch
from
74a3b1d
to
99c06cc
Compare
allbecauseyoutoldmeso
force-pushed
the
kg-proposal-details
branch
2 times, most recently
from
c344bb1
to
9a83bda
Compare
allbecauseyoutoldmeso
force-pushed
the
kg-proposal-details
branch
from
9a83bda
to
cdbf491
Compare
Description of change
Story Link
https://trello.com/c/3T7wafsB/1110-support-users-to-better-understand-proposal-detail-groups
Screenshot