Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC-0031: Implement vc-api interfaces for issuer and verifier #92

Closed
1 task done
toannvit opened this issue Jun 15, 2023 · 0 comments
Closed
1 task done

RFC-0031: Implement vc-api interfaces for issuer and verifier #92

toannvit opened this issue Jun 15, 2023 · 0 comments
Assignees
@toannvit
Milestone
MVP0

Comments

@toannvit
Copy link
Contributor

Description

Acceptance Criteria

  • Able to run an agent that use issue/verify router to issue/verify credential
@toannvit toannvit self-assigned this Jun 15, 2023
@toannvit toannvit mentioned this issue Jun 19, 2023
Merged
2 tasks
@hoa-ngo-gs hoa-ngo-gs added this to the MVP0 milestone Jun 21, 2023
arpentnoir pushed a commit that referenced this issue Jun 21, 2023
@toannvit
feat: vc-api issuer interfaces (#98)
eddb0c9 
# Issue
- #92 

#  Description
- Implement a plugin router implementing `vc-api-issuer` api interfaces
- RFC -
https://github.com/uncefact/project-vckit/tree/main/rfcs/features/0031-vc-api

# Changes 
- [x] Create plugin router (`vc-api-issuer`)
- [x] Change the agent.yml file to expose issuer apis

# Test results
<img width="467" alt="image"
src="https://github.com/uncefact/project-vckit/assets/17349449/df8b5fda-6086-4a34-8373-d195597dac0e">

---------

Signed-off-by: toanNgo <toan.ngo@gosource.com.au>
Co-authored-by: toanNgo <toan.ngo@gosource.com.au>
@toannvit toannvit mentioned this issue Jun 22, 2023
Closed
18 tasks
@namhoang1604 namhoang1604 mentioned this issue Jul 3, 2023
Merged
18 tasks
namhoang1604 added a commit that referenced this issue Jul 6, 2023
@namhoang1604
feat: vc api for the holder and the verifier (#107)
022fb56 
<!--
  For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
further details.
  
  For a timely review/response, please avoid force-pushing additional
  commits if your PR already received reviews or comments.
  
Before submitting a Pull Request, please ensure you've done the
following:
- 📖 Read the [Contributing
Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md).
- 📖 Read the [Code of
Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md).
  - 👷‍♀️ Create small PRs. In most cases, this will be possible.
  - ✅ Provide tests for your changes.
- 📝 Use descriptive commit messages following [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/).
- 📗 Update any related documentation and include any relevant
screenshots.
-->

## What type of PR is this? (check all applicable)

- [x] 🍕 Feature
- [ ] 🐛 Bug Fix
- [x] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [x] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

## Description

<!-- 
Please do not leave this blank 
This PR [adds/removes/fixes/replaces] the [feature/bug/etc]. 
-->
- Implement the vc-api for the holder and verifier.
- Implement the open api validator for the vc api router

```yaml
# API base path
- - $require: '@vckit/vc-api?t=function#HolderRouter'
- - $require: '@vckit/vc-api?t=function#IssuerRouter'
    $args:
      - createCredential: createVerifiableCredential
        updateCredentialStatus: updateVerifiableCredentialStatus
- - $require: '@vckit/vc-api?t=function#VerifierRouter'
    $args:
      - verifyCredential: verifyCredential
        verifyPresentation: verifyPresentation

# VC API docs path
- - /vc-api.json
  - $require: '@vckit/vc-api?t=function#VCApiSchemaRouter'
    $args:
      - basePath: :3332

- - /vc-api-docs
  - $require: '@vckit/vc-api?t=function#VCApiDocsRouter'
```

## Related Tickets & Documents
<!-- 
Please use this format link issue numbers: Fixes #123

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
#100
#92
#115

## Mobile & Desktop Screenshots/Recordings

<!-- Visual changes require screenshots -->

<img width="1510" alt="image"
src="https://github.com/uncefact/project-vckit/assets/13606809/5168be6a-ae27-4b6c-b4d4-7b51d8175d27">

<img width="536" alt="image"
src="https://github.com/uncefact/project-vckit/assets/13606809/1a1d08e8-fc02-48f5-aced-1ec56a2c24b5">

<img width="426" alt="image"
src="https://github.com/uncefact/project-vckit/assets/13606809/181eac6d-0998-4f31-9686-d855c2c6e626">





## Added tests?

- [x] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help

## Added to documentation?

- [x] 📜 README.md
- [ ] 📓 [vc-kit doc site](https://uncefact.github.io/vckit/)
- [ ] 📕 storybook
- [ ] 🙅 no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?


<!-- note: PRs with deleted sections will be marked invalid -->

---------

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
namhoang1604 added a commit to namhoang1604/project-vckit that referenced this issue Aug 21, 2023
@namhoang1604 @hoa-ngo-gs
feat: implement component for apple wallet and integrate visa grant (u…
9847f1d 
…ncefact#92)

* feat: add visa grant template

(cherry picked from commit 60814a5)

* feat: implement wallet package and integrate with apple wallet

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>

* feat: integrate with Student Visa Grant template

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>

---------

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
Co-authored-by: Hoa Ngo <hoa.ngo@gosource.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toannvit toannvit

Labels
None yet
Projects
None yet
Milestone
MVP0
Development

Successfully merging a pull request may close this issue.

feat: implement vc api verifier router gs-gs/project-vckit
4 participants
@onthebreeze @namhoang1604 @toannvit @hoa-ngo-gs