Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setup ci cd #154

Merged
merged 11 commits into from
Sep 5, 2023
Merged

chore: setup ci cd #154

merged 11 commits into from
Sep 5, 2023

Conversation

namhoang1604
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

This PR adds the CICD scripts

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 vc-kit doc site
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@namhoang1604
chore: setup CICD to deploy to S3 (uncefact#85)
2605715 
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
(cherry picked from commit 46b7fc2)
@namhoang1604
chore: fix version pnpm for github action
d4b4f23 
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
(cherry picked from commit c49af42)
@namhoang1604
chore: add scripts for CICD
bdea44b 
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
(cherry picked from commit 494139a)
@namhoang1604
chore: setup CICD
7761e2a 
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
(cherry picked from commit 770802f)
@namhoang1604
feat: implement logger
8933ae8 
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
(cherry picked from commit 4680887)
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
@namhoang1604
chore: update script CICD
9d01b02 
(cherry picked from commit 532b3c6)
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
@namhoang1604
chore: set environment for github action
716cbc7 
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
kshychko
kshychko requested changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@kshychko kshychko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two moments that I'd like to address:

  1. we need a simple setup for AWS credentials, so I added secrets for IAM user, but ket the role assume action.
  2. the FE is going to be deployed under /vckit/explorer/ path, so files needs to copied to s3 respectfully.

.github/workflows/deploy-to-s3.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-to-s3.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-to-s3.yml Outdated Show resolved Hide resolved
@namhoang1604
chore: change the configuration file location
07212bf 
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
@namhoang1604
chore: set database connection
84b6d07 
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
@namhoang1604 namhoang1604 merged commit 9febd39 into uncefact:next Sep 5, 2023
namhoang1604 added a commit to gs-gs/project-vckit that referenced this pull request Sep 6, 2023
@namhoang1604
chore: setup ci cd (uncefact#154)
cafcd30 
<!--
  For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
further details.

  For a timely review/response, please avoid force-pushing additional
  commits if your PR already received reviews or comments.

Before submitting a Pull Request, please ensure you've done the
following:
- 📖 Read the [Contributing
Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md).
- 📖 Read the [Code of
Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md).
  - 👷‍♀️ Create small PRs. In most cases, this will be possible.
  - ✅ Provide tests for your changes.
- 📝 Use descriptive commit messages following [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/).
- 📗 Update any related documentation and include any relevant
screenshots.
-->

- [ ] 🍕 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [x] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

<!--
Please do not leave this blank
This PR [adds/removes/fixes/replaces] the [feature/bug/etc].
-->
This PR adds the CICD scripts
<!--
Please use this format link issue numbers: Fixes uncefact#123

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

<!-- Visual changes require screenshots -->

- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help

- [ ] 📜 README.md
- [ ] 📓 [vc-kit doc site](https://uncefact.github.io/vckit/)
- [ ] 📕 storybook
- [ ] 🙅 no documentation needed

<!-- note: PRs with deleted sections will be marked invalid -->

---------

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
namhoang1604 added a commit to gs-gs/project-vckit that referenced this pull request Mar 12, 2024
@namhoang1604
chore: setup ci cd (uncefact#154)
5c3d7cd 
<!--
  For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
further details.

  For a timely review/response, please avoid force-pushing additional
  commits if your PR already received reviews or comments.

Before submitting a Pull Request, please ensure you've done the
following:
- 📖 Read the [Contributing
Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md).
- 📖 Read the [Code of
Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md).
  - 👷‍♀️ Create small PRs. In most cases, this will be possible.
  - ✅ Provide tests for your changes.
- 📝 Use descriptive commit messages following [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/).
- 📗 Update any related documentation and include any relevant
screenshots.
-->

- [ ] 🍕 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [x] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

<!--
Please do not leave this blank
This PR [adds/removes/fixes/replaces] the [feature/bug/etc].
-->
This PR adds the CICD scripts
<!--
Please use this format link issue numbers: Fixes uncefact#123

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

<!-- Visual changes require screenshots -->

- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help

- [ ] 📜 README.md
- [ ] 📓 [vc-kit doc site](https://uncefact.github.io/vckit/)
- [ ] 📕 storybook
- [ ] 🙅 no documentation needed

<!-- note: PRs with deleted sections will be marked invalid -->

---------

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
@ldhyen99 ldhyen99 mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoa-ngo-gs hoa-ngo-gs Awaiting requested review from hoa-ngo-gs

@kshychko kshychko Awaiting requested review from kshychko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namhoang1604 @kshychko