Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement vc api v2 in open api #178

Merged
merged 6 commits into from
May 14, 2024
Merged

Conversation

ldhyen99
Copy link
Collaborator

@ldhyen99 ldhyen99 commented May 8, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR implements the VC API v2 for VC data model v2. In VC API v2, user can:

In agent.yml in local, you should add this code to test:

- - /v1/vc-api
  - $require: '@vckit/vc-api?t=function#V1VcRouter'
    $args:
      - basePath: :3332
- - /v2/vc-api
  - $require: '@vckit/vc-api?t=function#V2VcRouter'
    $args:
      - basePath: :3332

Remember to comment these fields to test:

# # VC API
# - - $require: '@vckit/vc-api?t=function#VCRouter'
# # VC API docs path
# - - /vc-api.json
#   - $require: '@vckit/vc-api?t=function#VCApiSchemaRouter'
#     $args:
#       - basePath: :3332
# - - /vc-api-docs
#   - $require: '@vckit/vc-api?t=function#VCApiDocsRouter'

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@huynguyen-hl huynguyen-hl self-requested a review May 9, 2024 04:03
ldhyen99 and others added 3 commits May 10, 2024 15:18
@namhoang1604 namhoang1604 merged commit db8b185 into next May 14, 2024
@namhoang1604 namhoang1604 deleted the feat/implement_vc_api_v2 branch May 14, 2024 10:42
ducpm511 added a commit that referenced this pull request May 17, 2024
* next:
  chore: fix version of react
  feat: implement vc api v2 in open api (#178)

# Conflicts:
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants