Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

The Edit Details button on the create wallet interstitial page shouldn't clear the wallet #109

Closed
1 of 5 tasks
waldenraines opened this issue May 20, 2020 · 1 comment
Closed
1 of 5 tasks
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@waldenraines
Copy link
Contributor

waldenraines commented May 20, 2020

I'm submitting a…

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report
  • Feature request
  • Documentation issue or request
  • Support request

Expected Behavior

I would have expected the edit details button on the wallet confirmation page to take me back to the wallet creation page with all of my xpubs still imported. It would be highly annoying to set up 7 different hardware wallets and then have to do them all over because you made a mistake on the last one.

Current Behavior

All of the xpubs are cleared, see gif:

Peek 2020-05-20 15-10

Possible Solution

Don't clear the wallet.

Steps to Reproduce (for bugs)

  1. Import some xpubs or upload a wallet configuration file
  2. Click "Edit Details" button
  3. Notice that your entire wallet has been reset

Environment

  • Where are you running caravan: localhost
  • Operating system: Linux
  • Browser and version: Chrome
caravan@0.2.0 /home/walden/code/caravan
├── unchained-bitcoin@0.0.13 
└─┬ unchained-wallets@0.0.12 
  └── unchained-bitcoin@0.0.12 

npm: 6.14.4 
node: v12.16.2
Linux 5.6.13-arch1-1 #1 SMP PREEMPT Thu, 14 May 2020 06:52:53 +0000 x86_64 GNU/Linux
@jevidon
Copy link

jevidon commented Apr 1, 2024

The Caravan Library is transitioning to a new home, and as part of this move current issues will be closed and archived. This ticket will be addressed in the future as part of a broader UX overhaul, but you are welcome to recreate the issue if you would like: https://github.com/caravan-bitcoin/caravan/issues

@jevidon jevidon closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants