Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile only and forget about Travis CI #897

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

kaihendry
Copy link
Contributor

#750 which I think solves
#892 (comment)
because it locks down to .meteor/release

#750 which I think solves
#892 (comment)
because it locks down to .meteor/release
@kaihendry
Copy link
Contributor Author

Finally managed to get AWS CodeBuild to appear in the checks:

image

it's got to the point where I am fed up with Travis & I'd rather use the simpler Dockerfile driven approach of what I originally have here: https://github.com/unee-t/frontend/blob/master/buildspec.yml using CodeBuild @franck-boullier

And it succeeded:
image

So CodeBuild successfully now builds the Docker image and pushed the image to https://hub.docker.com/repository/registry-1.docker.io/uneet/frontend/tags?page=1

So Travis CI should ideally as before:

  • Do the deployment of a tagged build - this has to be checked since a lot of env stuff has changed
  • Do the CI npm t tests - not working and I've have spent hours on this

@franck-boullier
Copy link
Member

t's got to the point where I am fed up with Travis & I'd rather use the simpler Dockerfile driven approach of what I originally have here: https://github.com/unee-t/frontend/blob/master/buildspec.yml using CodeBuild @franck-boullier

OK sounds like a sensible approach indeed.

@kaihendry kaihendry merged commit 3cfd038 into master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants