Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .nvmrc #19

Merged
merged 1 commit into from
Nov 13, 2018
Merged

chore: add .nvmrc #19

merged 1 commit into from
Nov 13, 2018

Conversation

joelmukuthu
Copy link
Member

I just went full-circle from another project before finding #18 :)

I set it to v6 instead of v7 as 6 is an LTS version.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.141% when pulling e7659ae on chore/nvmrc into 9e61f9d on master.

@gustavnikolaj gustavnikolaj merged commit a31b94d into master Nov 13, 2018
@gustavnikolaj gustavnikolaj deleted the chore/nvmrc branch November 13, 2018 15:14
@gustavnikolaj
Copy link
Member

Thanks :-)

I am not sure what the future of this module will be though. I personally don't depend on anywhere critical enough to have me pick up maintenance of the mock-fs-fork that we are running. Just a headsup, before you tie yourself to a sinking ship 🚢

I like the idea of this module, but lately I've found myself just using a mix of fixture folders and tmp directories. It is a bit more manual labor and a bit more verbose, but it still feels like less effort than getting this up to date and keep it there :-)


For the record, the problem with mock-fs is that it basically carries around a modified version of fs.js from node core per version of node. So there is going to be a non trivial amount of work involved staying up to date with their changes. I'm no longer convinced that this is worth that effort. But it's a shame to give up a nice abstraction like this :-)

@gustavnikolaj
Copy link
Member

I'd probably bet my money on fileception going forward, but that probably has the exact same issues at the moment. https://github.com/papandreou/fileception

@joelmukuthu
Copy link
Member Author

ping @gustavnikolaj @papandreou :)

@joelmukuthu
Copy link
Member Author

Oops, sorry. I pinged before first attempting to reload my browser tab.

@gustavnikolaj that's alright and thanks for the info. I just ran into the issue while trying to run CI on newer node versions on unexpected-knex. All the same I agree that the effort in trying to mock out fs is probably not justifiable, and in ensuring tests are passing in all target environments then it's perhaps better to use fixtures stored on disk.

@papandreou
Copy link
Member

Yeah, fileception suffers from the same problem :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants