Skip to content
This repository was archived by the owner on Apr 3, 2023. It is now read-only.

feat: First part of the exposition of the Asso, Event, and UE entities #24

Merged
merged 9 commits into from
Jan 27, 2023
Merged

feat: First part of the exposition of the Asso, Event, and UE entities #24

merged 9 commits into from
Jan 27, 2023

Conversation

ThomasRitaine
Copy link
Contributor

@ThomasRitaine ThomasRitaine commented Dec 4, 2021 •
edited by TeddyRoncin
Loading

Description

  • Added the group and item request to the three entities
  • Added a partial name filter to Asso
  • Added event (id, name) list to item Asso
  • Added an exact code filter for UEs
  • Various (use) mandatory for filters and groups

Checklist

Implementation

  • Files and variables have a name explaining what they do.
  • Updating the DB schemas and seeding the tables do not generate errors.
  • All code repeated more than 2 times has been refactored in a dedicated file or function.
  • Debugs have been removed : dd() | dump()

Tools

  • PHP CS Fixer has fixed all files inside the src folder.
  • All commits have been done using Commitizen.

Documentation

  • All new classes and non-trivial functions have a code documentation.
  • There are comments to explain complex parts inside your code.
  • If a new folder is created, it has been added and explained inside the "Folder structure" part of the README.md file.

ThomasRitaine
ThomasRitaine commented Dec 4, 2021
View reviewed changes
Copy link
Contributor Author

@ThomasRitaine ThomasRitaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review de la partie asso

nicholsp2 and others added 5 commits January 27, 2023 11:16
@nicholsp2
feat: First part of the exposition of the Asso Event and UE entities
2beba73
🐛 (Asso) Fixed a few problems of PR#24
3f93be5 
createdAt and keywords are now exposed. Fixed import errors. Linted a space. Merged both class annotations in the same #[]. Added a sort based on the asso name. Added a filter on keywords
🐛 (Routes /assos) Polished the PR
befa0c4 
null values will now be returned in routes /assos, /events and /ues. Descriptions are now returned in route GET /assos (short description) and GET /assos/{id} (long description). Memberships and
membership count are now exposed.
🐛 (/ues and /events) These files should have been in the previous PR.…
e5edc9d 
… null values were not sent

set attribute "skip_null_values" to false in the exposition of /ues and /events
🐛 (/ues, /events) Polishing
eaff277 
Added security for /ues and /events routes. Parameters of ApiResource are now in the right order for files UE, Event and Asso. Changed filter for UE searching from exact to partial
@TeddyRoncin TeddyRoncin force-pushed the features/FirstEntitiesChanges branch from e98c313 to eaff277 Compare January 27, 2023 10:17
@TeddyRoncin TeddyRoncin merged commit 491e734 into dev Jan 27, 2023
@TeddyRoncin TeddyRoncin deleted the features/FirstEntitiesChanges branch January 27, 2023 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasRitaine @TeddyRoncin @nicholsp2