fix: fix HBuilderX compatibility #40

Skiyee · 2024-05-21T10:36:29Z

兼容HBuilderX
检查创建模式
优化性能

Summary by CodeRabbit

New Features
- Added dynamic path handling for pages.json configuration, allowing flexibility based on input options.
Improvements
- Simplified logic for determining pageJsonPath, enhancing maintainability and readability.
- Enhanced string manipulation with a new slash function.

coderabbitai · 2024-05-21T10:36:38Z

Walkthrough

The recent updates enhance the handling of pages.json paths in the Context class and VitePluginUniLayouts function. Context now features a pageJsonPath property, while VitePluginUniLayouts dynamically sets this path based on user options. The refactored src/utils.ts file simplifies string manipulation by replacing isCLIMode with the new slash function.

Changes

File	Change Summary
`src/context.ts`	Added `pageJsonPath` property to `Context` class, initialized to `'src/pages.json'`. Updated `loadPagesJson` to use this property.
`src/index.ts`	Introduced `buildStart` function in `VitePluginUniLayouts` to set `pageJsonPath` based on input options.
`src/utils.ts`	Replaced `isCLIMode` function with `slash` function for string manipulation. Simplified logic in `loadPagesJson` and `getTarget`.

🐰 In the land where code does dance,
Paths now change with circumstance.
pages.json finds its way,
Simplified for a brighter day.
With slash in hand, we take our stance,
To make our plugins sing and prance. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Xiphin · 2024-05-21T10:39:38Z

LGTM 💖

coderabbitai

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

src/context.ts (1)

Line range hint 38-50: Repeated calls to loadPagesJson could be optimized. Consider caching the results or checking if the file has changed before reloading.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4ca0e5d and 84e6bc4.

Files selected for processing (3)

src/context.ts (3 hunks)
src/index.ts (1 hunks)
src/utils.ts (3 hunks)

Additional comments not posted (3)

src/index.ts (1)

20-22: Ensure the input options structure is well-documented to avoid confusion.

src/utils.ts (1)

10-11: The slash function correctly normalizes path separators.

src/context.ts (1)

18-24: Initialization of pageJsonPath centralizes the path definition, enhancing maintainability.

coderabbitai · 2024-05-21T10:41:20Z

src/utils.ts

-    throw new Error('Can\'t find pages.json')
-
-  const pagesJsonRaw = readFileSync(pageJsonPath, {
+  const pagesJsonRaw = readFileSync(resolve(cwd, path), {


Consider adding error handling for file reading and JSON parsing in loadPagesJson.

- const pagesJsonRaw = readFileSync(resolve(cwd, path), { + try { + const pagesJsonRaw = readFileSync(resolve(cwd, path), { encoding: 'utf-8', }) const { pages = [], subPackages = [] } = jsonParse(pagesJsonRaw) + } catch (error) { + console.error('Failed to read or parse pages.json:', error); + return []; + }

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

const pagesJsonRaw = readFileSync(resolve(cwd, path), {

try {

const pagesJsonRaw = readFileSync(resolve(cwd, path), {

encoding: 'utf-8',

})

const { pages = [], subPackages = [] } = jsonParse(pagesJsonRaw)

} catch (error) {

console.error('Failed to read or parse pages.json:', error);

return [];

}

Skiyee · 2024-05-23T02:06:19Z

暂时别合并，在 H5端 表现异常

Xiphin · 2024-05-23T02:22:32Z

暂时别合并，在 H5端 表现异常

H5 下拿不到 input

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 84e6bc4 and 460cbae.

Files selected for processing (2)

src/index.ts (1 hunks)
src/utils.ts (3 hunks)

Files skipped from review as they are similar to previous changes (2)

src/index.ts
src/utils.ts

Skiyee · 2024-05-23T03:53:18Z

用回 existsSync, 仅在服务器启动时判断一次，性能可忽略不计？
由于 H5 和 非H5 在vite中表现不一致，目前只能采用这种方法

Skiyee · 2024-05-23T03:58:43Z

暂时别合并，在 H5端 表现异常

H5 下拿不到 input

朋友，测试一下在 HBX 是否正常

Xiphin · 2024-05-23T04:09:25Z

暂时别合并，在 H5端 表现异常

H5 下拿不到 input

朋友，测试一下在 HBX 是否正常

H5 dev 通过
H5 build 通过
mp-weixin dev 通过
mp-weixin build 通过

ModyQyW · 2024-05-24T02:03:58Z

thx

fix: fix HBuilderX compatibility

84e6bc4

Xiphin mentioned this pull request May 21, 2024

fix: fix HBuilderX compatibility #39

Closed

coderabbitai bot reviewed May 21, 2024

View reviewed changes

update: h5 compatibility

460cbae

pull-request-size bot added the size/M label May 23, 2024

coderabbitai bot reviewed May 23, 2024

View reviewed changes

ModyQyW merged commit 28e26a6 into uni-helper:main May 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix HBuilderX compatibility #40

fix: fix HBuilderX compatibility #40

Skiyee commented May 21, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 21, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Xiphin commented May 21, 2024

coderabbitai bot left a comment

coderabbitai bot May 21, 2024

Skiyee commented May 23, 2024

Xiphin commented May 23, 2024 •

edited

Loading

coderabbitai bot left a comment

Skiyee commented May 23, 2024 •

edited

Loading

Skiyee commented May 23, 2024

Xiphin commented May 23, 2024

ModyQyW commented May 24, 2024

-  const pagesJsonRaw = readFileSync(resolve(cwd, path), {
+  try {
+    const pagesJsonRaw = readFileSync(resolve(cwd, path), {
+      encoding: 'utf-8',
+    })
+    const { pages = [], subPackages = [] } = jsonParse(pagesJsonRaw)
+  } catch (error) {
+    console.error('Failed to read or parse pages.json:', error);
+    return [];
+  }

fix: fix HBuilderX compatibility #40

fix: fix HBuilderX compatibility #40

Conversation

Skiyee commented May 21, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented May 21, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Xiphin commented May 21, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot May 21, 2024

Choose a reason for hiding this comment

Skiyee commented May 23, 2024

Xiphin commented May 23, 2024 • edited Loading

coderabbitai bot left a comment

Choose a reason for hiding this comment

Skiyee commented May 23, 2024 • edited Loading

Skiyee commented May 23, 2024

Xiphin commented May 23, 2024

ModyQyW commented May 24, 2024

Skiyee commented May 21, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 21, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

Xiphin commented May 23, 2024 •

edited

Loading

Skiyee commented May 23, 2024 •

edited

Loading