Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZeroTrie follow-ups #3894

Open
4 tasks
sffc opened this issue Aug 18, 2023 · 0 comments
Open
4 tasks

ZeroTrie follow-ups #3894

sffc opened this issue Aug 18, 2023 · 0 comments
Assignees
@sffc
Labels
C-zerovec Component: Yoke, ZeroVec, DataBake S-medium Size: Less than a week (larger bug fix or enhancement)
Milestone
2.x Priority ⟨P2⟩

Comments

@sffc
Copy link
Member

sffc commented Aug 18, 2023 •
edited

The big ZeroTrie PR was merged as #2722

  • Clarify what "bracket a window of strings" means in builder/mod.rs
  • Should the get function be bounded on AsRef or Borrow? If Borrow, then get_str needs to be added
  • Add DataBake impls and test whether they negatively impact compile times
  • ZeroTrie types simplification #4408: Run performance benchmarks again to see if we can consolidate the flavors of ZeroTrie down to two or one
@sffc sffc added S-medium Size: Less than a week (larger bug fix or enhancement) C-zerovec Component: Yoke, ZeroVec, DataBake labels Aug 18, 2023
@sffc sffc added this to the 1.x Priority ⟨P2⟩ milestone Aug 18, 2023
@sffc sffc self-assigned this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-zerovec Component: Yoke, ZeroVec, DataBake S-medium Size: Less than a week (larger bug fix or enhancement)
Projects
None yet
Milestone
2.x Priority ⟨P2⟩
Development

No branches or pull requests
1 participant
@sffc