Construct VZVs and use as_encoded_bytes instead of the static function #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Dec 19, 2021
Manishearth
previously approved these changes
Dec 19, 2021
|
Pushed fixes to deal with #1412 |
Manishearth
previously approved these changes
Dec 19, 2021
|
It seems there's a bug in GitHub that when someone pushes to a branch, it invalidates certain PRs (maybe ones that have a merge commit). Feel free to merge when you re-approve. |
Manishearth
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that's annoyed me for a while. We can now do this at zero cost, so let's do it.
Do note that this raises questions with regard to error handling, but these questions already existed before. I filed #1410 and left TODOs linked to that issue.