Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExportableDataPayload::eq_dyn #3639

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Add ExportableDataPayload::eq_dyn #3639

merged 6 commits into from
Jul 6, 2023

Conversation

sffc
Copy link
Member

@sffc sffc commented Jul 5, 2023

Toward #2683

@sffc sffc requested a review from Manishearth as a code owner July 5, 2023 15:37
@sffc sffc requested a review from robertbastian July 5, 2023 15:37
@sffc
Copy link
Member Author

sffc commented Jul 5, 2023

The build failure is because I need to add more PartialEq impls. Good news is it seems I need only these 6:

error[E0277]: can't compare `icu_list::provider::ListFormatterPatternsV1<'a>` with `icu_list::provider::ListFormatterPatternsV1<'a>`

error[E0277]: can't compare `icu_properties::provider::names::PropertyValueNameToEnumMapV1<'a>` with `icu_properties::provider::names::PropertyValueNameToEnumMapV1<'a>`

error[E0277]: can't compare `icu_properties::provider::names::PropertyEnumToValueNameLinearMapV1<'a>` with `icu_properties::provider::names::PropertyEnumToValueNameLinearMapV1<'a>`

error[E0277]: can't compare `icu_properties::provider::names::PropertyEnumToValueNameSparseMapV1<'a>` with `icu_properties::provider::names::PropertyEnumToValueNameSparseMapV1<'a>`

error[E0277]: can't compare `icu_properties::provider::names::PropertyEnumToValueNameLinearTiny4MapV1<'a>` with `icu_properties::provider::names::PropertyEnumToValueNameLinearTiny4MapV1<'a>`

error[E0277]: can't compare `WeekDataV1` with `WeekDataV1`

Manishearth
Manishearth previously approved these changes Jul 5, 2023
robertbastian
robertbastian previously approved these changes Jul 5, 2023
Manishearth
Manishearth previously approved these changes Jul 5, 2023
@sffc sffc dismissed stale reviews from Manishearth and robertbastian via 1b7b159 July 6, 2023 09:20
@sffc sffc requested a review from a team as a code owner July 6, 2023 09:20
@sffc sffc requested a review from robertbastian July 6, 2023 09:54
@sffc sffc merged commit 0f57d72 into unicode-org:main Jul 6, 2023
@sffc sffc deleted the eq_dyn branch July 6, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants