Clean up icu_datetime/experimental
#4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
dt-exp
branch
from
f5d3bdd
to
d883f76
Compare
robertbastian
commented
Sep 26, 2023
| @@ -210,26 +203,36 @@ impl<C: CldrCalendar> TypedZonedDateTimeFormatter<C> { | |||
| /// Constructor that takes a selected locale and a list of [`DateTimeFormatterOptions`]. | |||
| /// It collects all data necessary to format zoned datetime values into the given locale. | |||
| /// | |||
| /// ✨ *Enabled with the `compiled_data` Cargo feature.* | |||
| /// ✨ *Enabled with the `compiled_data` and `experimental` Cargo features.* | |||
There was a problem hiding this comment.
this looks messy because I changed the order, putting the non-experimental constructors first. this line is the only other change
robertbastian
requested review from
zbraniecki,
gregtatum and
nordzilla
as code owners
robertbastian
requested review from
sffc
and removed request for
zbraniecki,
gregtatum and
nordzilla
sffc
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill in doc comments Cargo feature boilerplate and reduce the number of
#[cfg(feature = "experimental")]gates.