Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compiled data for tinywasm #4163

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

robertbastian
Copy link
Member

No description provided.

@@ -29,9 +29,6 @@ def main():
is_export = False
elif arg == "--export":
is_export = True
elif arg == "--export-dynamic":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sffc
Copy link
Member

sffc commented Oct 16, 2023

On main:

-rwxr-xr-x 1 root root 68499 Oct 16 19:25 icu_capi.wasm
-rw-r--r-- 1 root root 11613 Oct 16 19:27 data.postcard

In this PR:

-rwxr-xr-x 1 root root 76484 Oct 14 08:15 icu_capi.wasm

I was about to approve but shouldn't this metric be going in the other direction?

EDIT: Forgot to add data.postcard which we can remove now. Overall size is smaller as expected.

@robertbastian robertbastian merged commit ee9877b into unicode-org:main Oct 17, 2023
28 checks passed
@robertbastian robertbastian deleted the fix-tinywasm branch October 17, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants