icu_capi clippy cleanup
#4355
Merged
icu_capi clippy cleanup
#4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Nov 23, 2023
| #[diplomat::attr(dart, rename = "length")] | ||
| pub fn len(&self) -> usize { | ||
| self.0.len() | ||
| } | ||
|
|
||
| /// Whether this map is empty | ||
| pub fn is_empty(&self) -> bool { |
There was a problem hiding this comment.
issue: I don't think we should have this over ffi, it's very much a Rust convention
There was a problem hiding this comment.
Using foo.isEmpty() instead of foo.length() == 0 is a readability improvement that is mandated by many style guides and languages. This means we need to expose this in order to have idiomatic FFI.
There was a problem hiding this comment.
I guess, though we should probably be applying more renames then
(Not that we can pre-JS HIR)
Manishearth
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.