-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating provider_cldr and testdata to CLDR 38.1.0-BETA4 #441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 74.92% 74.90% -0.03%
==========================================
Files 90 90
Lines 4662 4658 -4
==========================================
- Hits 3493 3489 -4
Misses 1169 1169
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 53fea1f91066148e0f3d6ebef8461124f0a86557-PR-441
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Fixes #409
Depends on #407
I implemented a downloader for the new all-in-one CLDR JSON distribution. I can't switch the testdata over to CLDR 38, though, until we support the "e" operand. Right now I get the error: