Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating provider_cldr and testdata to CLDR 38.1.0-BETA4 #441

Merged
merged 9 commits into from
Jan 11, 2021

Conversation

sffc
Copy link
Member

@sffc sffc commented Jan 8, 2021

Fixes #409
Depends on #407

I implemented a downloader for the new all-in-one CLDR JSON distribution. I can't switch the testdata over to CLDR 38, though, until we support the "e" operand. Right now I get the error:

thread 'main' panicked at 'Rule parsing failed.: ExpectedOperand', components/provider_cldr/src/transform/plurals.rs:141:47

@sffc sffc requested a review from zbraniecki January 8, 2021 03:23
@sffc sffc requested a review from srl295 January 8, 2021 03:25
@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #441 (8f1bda3) into master (2a9adbc) will decrease coverage by 0.02%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   74.92%   74.90%   -0.03%     
==========================================
  Files          90       90              
  Lines        4662     4658       -4     
==========================================
- Hits         3493     3489       -4     
  Misses       1169     1169              
Impacted Files Coverage Δ
...omponents/provider_fs/src/bin/icu4x-cldr-export.rs 0.87% <0.00%> (ø)
...onents/provider_cldr/src/download/cldr_allinone.rs 27.27% <11.11%> (ø)
components/provider_cldr/src/download/io_util.rs 40.00% <16.66%> (-2.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a9adbc...8f1bda3. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 8, 2021

Pull Request Test Coverage Report for Build 53fea1f91066148e0f3d6ebef8461124f0a86557-PR-441

  • 2 of 20 (10.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 74.06%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/provider_fs/src/bin/icu4x-cldr-export.rs 0 1 0.0%
resources/testdata/src/bin/icu4x-gen-testdata.rs 0 4 0.0%
components/provider_cldr/src/download/io_util.rs 1 6 16.67%
components/provider_cldr/src/download/cldr_allinone.rs 1 9 11.11%
Files with Coverage Reduction New Missed Lines %
resources/testdata/src/bin/icu4x-gen-testdata.rs 2 1.47%
Totals Coverage Status
Change from base Build 2a9adbca47e13371a314f5d98d0a48f3a2407916: -0.05%
Covered Lines: 3603
Relevant Lines: 4865

💛 - Coveralls

srl295
srl295 previously approved these changes Jan 8, 2021
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/provider_cldr/src/download/cldr_components.rs Outdated Show resolved Hide resolved
@dpulls
Copy link

dpulls bot commented Jan 9, 2021

🎉 All dependencies have been resolved !

@sffc sffc changed the title Implementing CLDR 38 style JSON downloader Updating provider_cldr and testdata to CLDR 38.1.0-BETA4 Jan 9, 2021
zbraniecki
zbraniecki previously approved these changes Jan 9, 2021
@sffc sffc requested a review from zbraniecki January 11, 2021 10:46
Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sffc sffc merged commit 273ec28 into unicode-org:master Jan 11, 2021
@sffc sffc deleted the cldr38 branch January 11, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to CLDR 38
5 participants