(icu_datagen 1.4.1) Remove fraction dep from icu_datagen #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
sffc,
robertbastian and
a team
as code owners
Backports unicode-org#4459 Unlike that PR, this makes these deps dev-deps since they're not yet used by an experimental feature
Manishearth
force-pushed
the
backport-fractional
branch
from
7583943
to
f90b2c1
Compare
robertbastian
approved these changes
Dec 19, 2023
|
Going to wait for @sffc approval before publishing |
|
Unfortunately this is insufficient for being able to run tests in google3. It's worth thinking about if we want to avoid having "datagen tests that are |
|
Either way, tests are broken for manifest_dir reasons as well, so not worth trying to fix them in a backport. |
sffc
approved these changes
Dec 19, 2023
|
Published icu_datagen 1.4.1. Main PR for changelog in #4474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #4459 and #4458
Backport approved in #4458
Unlike that PR, this makes these deps dev-deps since they're not yet
used by an experimental feature