Rename write_cmp_bytes to writeable_cmp_bytes #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
robertbastian,
Manishearth,
zbraniecki,
nciric and
a team
as code owners
|
If possible I'd like LGTMs from multiple organizations on this function name. |
|
Note that we chose |
robertbastian
previously approved these changes
Apr 11, 2024
| @@ -351,7 +351,7 @@ macro_rules! impl_display_with_writeable { | |||
| /// - Equality of string content | |||
| /// - Equality of parts ([`*_parts_eq`] only) | |||
| /// - Validity of size hint | |||
| /// - Reflexivity of `cmp_bytes` | |||
| /// - Reflexivity of `cmp_bytes` and order against largest and smallest strings | |||
There was a problem hiding this comment.
nice, I was thinking about adding this
Manishearth
previously approved these changes
Apr 11, 2024
sffc
commented
Apr 12, 2024
robertbastian
approved these changes
Apr 12, 2024
|
Waiting on ballot results |
|
This name won the ballot. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4402, #4741, #4787
I had landed these functions but we never bikeshed their names. We did bikeshed
writeable_length_hinthere, so I'm taking that answer and applying it to this similar function. It should be namedwriteable_cmp_bytessince it isn't actually writing anything; it's only a function on the Writeable trait.