Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests that rely on nonexistent bad-option error #740

Closed
wants to merge 1 commit into from

Conversation

catamorphism
Copy link
Collaborator

I suggest we remove these two tests for now, because the property that they are testing is actually underspecified. There is nothing in errors.md corresponding to the bad-option error, and what's more, the spec doesn't require :number to signal an error for a non-integer minimumFractionDigits value.

I filed #738 and #739 to clarify those issues in the spec, but I think the tests should be removed in the meantime, and re-added once the behavior is fully specified.

This error has nothing corresponding to it in the spec.
The tests can be re-added once
unicode-org#738
is resolved.
@aphillips
Copy link
Member

I think this would be a mistake. I agree that there is no specific bad-option error. I think we should fix registry.md for some of the cases you point out. I think that number formatting is so common that these options should be well-clarified now--and that there will be general agreement about how to do that. I think these tests should be retained.

@aphillips aphillips added LDML45 LDML45 Release (Tech Preview) test-suite labels Mar 19, 2024
@aphillips
Copy link
Member

Note: I made #741 to (try to) address part of the gap. It doesn't mess with the bad-option problem.

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these should be dropped. The right fix here would be to better define the behaviour for :number minimumFractionDigits=foo, which should indeed be considered an error.

@aphillips aphillips added resolve-candidate This issue appears to have been answered or resolved, and may be closed soon. Agenda+ labels Mar 21, 2024
@aphillips
Copy link
Member

I'm marking this for Monday's agenda. I used resolve-candidate because at least two of us feel that this shouldn't go in, but that doesn't mean the WG won't feel differently.

@aphillips aphillips closed this Mar 25, 2024
@aphillips
Copy link
Member

In the 2024-03-25 call we agreed not to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda+ LDML45 LDML45 Release (Tech Preview) resolve-candidate This issue appears to have been answered or resolved, and may be closed soon. test-suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants