Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glib_compat #1945

Closed
wants to merge 1 commit into from
Closed

Conversation

vlasta-labsky
Copy link

Fixes #1943

@aquynh
Copy link
Member

aquynh commented Apr 27, 2024 via email

@vlasta-labsky
Copy link
Author

I haven't tried windows, it may took a while for me to prepare windows build environment (not windows user) ...
It looks that upstream glib supports win builds, so maybe it works just fine.
The issue #1943 that I want to solve is less likely to happen on windows - Qt for windows does not use glib,
and I think there are not many programs/libraries that use glib on windows.
The best option would be to eliminate glib dependency (even the system one) but that it beyond my capabilities.

@wtdcode
Copy link
Member

wtdcode commented Apr 28, 2024

As suggested above, this breaks windows. See CI.

@vlasta-labsky
Copy link
Author

I looked at the CI build errors and they are related to missing pkgconfig and/or glib upstream packages - this patch introduces new dependency on upstream glib to replace glib_compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants